fix(server): Prefetch the correct binding artifacts#2298
Open
Vampire wants to merge 1 commit into
Open
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
Vampire
force-pushed
the
vampire/fix-prefetching
branch
from
2bff3b1 to
9df19ea
Compare
Vampire
force-pushed
the
vampire/fix-maven-metadata-artifact-name
branch
from
8c04cf9 to
f1e0102
Compare
Vampire
force-pushed
the
vampire/fix-prefetching
branch
2 times, most recently
from
52b8a6a to
c3dce5a
Compare
Vampire
force-pushed
the
vampire/fix-maven-metadata-artifact-name
branch
2 times, most recently
from
4315cce to
ed78050
Compare
Vampire
force-pushed
the
vampire/fix-prefetching
branch
from
c3dce5a to
4a77e9d
Compare
This was referenced Apr 24, 2026
Vampire
force-pushed
the
vampire/fix-prefetching
branch
from
4a77e9d to
933b1aa
Compare
Vampire
force-pushed
the
vampire/fix-maven-metadata-artifact-name
branch
from
ed78050 to
4bd8399
Compare
Vampire
force-pushed
the
vampire/fix-prefetching
branch
from
933b1aa to
5b6c090
Compare
Vampire
force-pushed
the
vampire/fix-maven-metadata-artifact-name
branch
from
4bd8399 to
34fae11
Compare
Vampire
force-pushed
the
vampire/fix-prefetching
branch
from
5b6c090 to
be17b5c
Compare
Vampire
force-pushed
the
vampire/fix-maven-metadata-artifact-name
branch
from
34fae11 to
254d9cc
Compare
Vampire
force-pushed
the
vampire/fix-prefetching
branch
from
be17b5c to
a8b12c5
Compare
krzema12
reviewed
May 15, 2026
Member
There was a problem hiding this comment.
Can I ask you to surface the issue in a separate PR that adds tests showing the current behavior? Then, once merged, this PR will show the adjustment in the behavior that is brought by the fix - it will be easier for me to understand the fix.
Collaborator
Author
There was a problem hiding this comment.
I'm on vacation without computer right now.
When adding the new semantics to the coordinates, you did not adjust what is prefetched, and so the prefetching did prefetch things that were not going to be requested and thus it was useless.
Iirc it even tried to prefetch non-existent things and so did not do anything useful at all anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.